Repository navigation
ci: run Playwright only when the library or the test app change - #28
Merged
Merged
Conversation
The Playwright suite drives the library (src/) through the test app (test/), but it ran on every push and pull request, so website-only changes waited minutes for it. It moves to e2e.yml, which only runs when src/, test/, their build and Playwright config, the dependencies or the CI setup change. The release calls it explicitly, so nothing ships without it.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playwright only runs when the pull request (or the push) touches something it tests. A website- or docs-only change no longer waits for chromium and webkit.
Changes
New
e2e.yml: the Playwright job moves out ofci.ymlinto its own workflow, filtered by path. It runs onpushtomain/v2and on pull requests that touch:src/**,test/**;playwright.config.ts,vite.config.ts,tsconfig.json,tsconfig.lib.json;package.json,pnpm-lock.yaml,pnpm-workspace.yaml;.github/actions/setup/**(Node/pnpm versions) and the workflow itself.It no longer waits for
verify, because it builds the library itself, so the two run in parallel.ci.yml: keeps lint, types and the library and website builds, on every push and pull request.release.yml: callse2e.ymlexplicitly, andstagewaits forci,e2eandversion. A release runs Playwright whatever it changed.Docs:
AGENTS.mdandCONTRIBUTING.mddescribe the split.Checks
The three workflows parse, and the release's job graph is
stage ← ci + e2e + version. This PR touchese2e.yml, so it runs E2E itself. A PR that only toucheswebsite/will show only CI.